Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23654 )
Change subject: IMPALA-14488: Calcite planner: Support fallback to Original planner ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/23654/5/common/thrift/Query.thrift File common/thrift/Query.thrift: http://gerrit.cloudera.org:8080/#/c/23654/5/common/thrift/Query.thrift@157 PS5, Line 157: ALL_EXCEPTIONS = 0, : UNSUPPORTED_AND_NONQUERY = 1, : NONQUERY_ONLY = 2 > Hmmm...I did think about it. Actually, EXPLAIN_LEVEL value is also thrift enum in Types.thrift. // Level of verboseness for "explain" output. enum TExplainLevel { MINIMAL = 0 STANDARD = 1 EXTENDED = 2 VERBOSE = 3 } So it is fine as thrift enum, but probably should move to Types.thirft as well. I tempted to rename them shorter like this: enum TCalciteFallback { ANY = 0, UNSUPPORTED = 1, NON_SELECT = 2 } I think UNSUPPORTED is a superset of NON_SELECT. -- To view, visit http://gerrit.cloudera.org:8080/23654 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6413b478fd11b645d05a60313990cb2b8c015a67 Gerrit-Change-Number: 23654 Gerrit-PatchSet: 6 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Mon, 10 Nov 2025 23:26:48 +0000 Gerrit-HasComments: Yes
