Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/23226 )
Change subject: IMPALA-14460: Keep http connections open in impala-shell ...................................................................... Patch Set 11: (6 comments) Looks great! A few nits to look at. http://gerrit.cloudera.org:8080/#/c/23226/11/shell/impala_shell/ImpalaHttpClient.py File shell/impala_shell/ImpalaHttpClient.py: http://gerrit.cloudera.org:8080/#/c/23226/11/shell/impala_shell/ImpalaHttpClient.py@428 PS11, Line 428: self.close() Is there another way to delete http cookies instead of closing the socket? If so, the socket could stay open and eliminate one more reconnection. http://gerrit.cloudera.org:8080/#/c/23226/11/tests/custom_cluster/test_shell_jwt_auth.py File tests/custom_cluster/test_shell_jwt_auth.py: http://gerrit.cloudera.org:8080/#/c/23226/11/tests/custom_cluster/test_shell_jwt_auth.py@94 PS11, Line 94: # counting total number of RPCs is not trivial or stable, so ensure we have multiple. I agree this approach is good enough. The assert in line 90 is the most important assert. This particular assert is a nice-to-have double check. http://gerrit.cloudera.org:8080/#/c/23226/11/tests/custom_cluster/test_shell_jwt_auth.py@179 PS11, Line 179: query_rpc_count Nit: Please consider changing this variable name to be "query_connection_count" or something similar to reflect that rpc count is no longer used. http://gerrit.cloudera.org:8080/#/c/23226/11/tests/custom_cluster/test_shell_oauth_auth.py File tests/custom_cluster/test_shell_oauth_auth.py: http://gerrit.cloudera.org:8080/#/c/23226/11/tests/custom_cluster/test_shell_oauth_auth.py@95 PS11, Line 95: # counting total number of RPCs is not trivial or stable, so ensure we have multiple. I agree this approach is good enough. The assert in line 91 is the most important assert. This particular assert is a nice-to-have double check. http://gerrit.cloudera.org:8080/#/c/23226/11/tests/custom_cluster/test_shell_oauth_auth.py@135 PS11, Line 135: query_rpc_count Nit: Please consider changing this variable name to be "query_connection_count" or something similar to reflect that rpc count is no longer used. http://gerrit.cloudera.org:8080/#/c/23226/11/tests/custom_cluster/test_shell_oauth_auth.py@179 PS11, Line 179: query_rpc_count = self.__get_connection_count() - before_connection_count Nit: Please consider changing this variable name to be "query_connection_count" or something similar to reflect that rpc count is no longer used. -- To view, visit http://gerrit.cloudera.org:8080/23226 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If7a6c4f175cceca80f530b4d4355316d588730f0 Gerrit-Change-Number: 23226 Gerrit-PatchSet: 11 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Comment-Date: Mon, 10 Nov 2025 22:19:07 +0000 Gerrit-HasComments: Yes
