Arnab Karmakar has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23652 )

Change subject: IMPALA-13844: Add /stacks web page to dump native thread stacks
......................................................................


Patch Set 1:

(1 comment)

This patch still has quite a bit of work to be done. Quanlong has asked me to 
also include the jstack output in this after mapping the nid with the pid from 
pstack. Ill add the tests too along with it

http://gerrit.cloudera.org:8080/#/c/23652/1/be/src/util/default-path-handlers.cc
File be/src/util/default-path-handlers.cc:

http://gerrit.cloudera.org:8080/#/c/23652/1/be/src/util/default-path-handlers.cc@222
PS1, Line 222:       if (group[0].status.ok() && group[0].stack.HasCollected()) 
{
> Why does this section differ from https://github.com/apache/kudu/blob/d8a95
It provides better error handling, the Kudu counterpart doesnt take care of 
threads that fail to collect their stack traces.



--
To view, visit http://gerrit.cloudera.org:8080/23652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9171c89d1d36726d98a4a61ca040d69254f50e92
Gerrit-Change-Number: 23652
Gerrit-PatchSet: 1
Gerrit-Owner: Arnab Karmakar <[email protected]>
Gerrit-Reviewer: Arnab Karmakar <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Pranav Lodha <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Surya Hebbar <[email protected]>
Gerrit-Comment-Date: Mon, 10 Nov 2025 17:55:56 +0000
Gerrit-HasComments: Yes

Reply via email to