Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23154 )
Change subject: IMPALA-9846: Enable Aggregated Runtime Profile by Default ...................................................................... Patch Set 19: (5 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23154/19/common/thrift/Query.thrift File common/thrift/Query.thrift: http://gerrit.cloudera.org:8080/#/c/23154/19/common/thrift/Query.thrift@984 PS19, Line 984: 28: optional bool aggregated_profile Renaming field 'gen_aggregated_profile' to 'aggregated_profile' in TQueryCtx might break the compatibility between impalad and catalogd/statestore during upgrade http://gerrit.cloudera.org:8080/#/c/23154/19/tests/common/test_result_verifier.py File tests/common/test_result_verifier.py: http://gerrit.cloudera.org:8080/#/c/23154/19/tests/common/test_result_verifier.py@584 PS19, Line 584: w flake8: E501 line too long (131 > 90 characters) http://gerrit.cloudera.org:8080/#/c/23154/19/tests/common/test_result_verifier.py@641 PS19, Line 641: def try_compile_profile_search_object(row_string, agg_profile=True): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/23154/19/tests/query_test/test_parquet_bloom_filter.py File tests/query_test/test_parquet_bloom_filter.py: http://gerrit.cloudera.org:8080/#/c/23154/19/tests/query_test/test_parquet_bloom_filter.py@183 PS19, Line 183: 1 flake8: E501 line too long (98 > 90 characters) http://gerrit.cloudera.org:8080/#/c/23154/19/tests/query_test/test_parquet_bloom_filter.py@185 PS19, Line 185: 0 flake8: E501 line too long (98 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/23154 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If41d6322361fba82c946efd614cc7d28cb1c36e8 Gerrit-Change-Number: 23154 Gerrit-PatchSet: 19 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Mon, 10 Nov 2025 10:50:12 +0000 Gerrit-HasComments: Yes
