Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/23569 )
Change subject: IMPALA-14507: Register column-level privilege requests for INSERT ...................................................................... Patch Set 7: (2 comments) In patch set 7, I have addressed Riza's comments on patch set 5. Let me know if there are additional suggestions. Thanks! http://gerrit.cloudera.org:8080/#/c/23569/5/fe/src/main/java/org/apache/impala/authorization/BaseAuthorizationChecker.java File fe/src/main/java/org/apache/impala/authorization/BaseAuthorizationChecker.java: http://gerrit.cloudera.org:8080/#/c/23569/5/fe/src/main/java/org/apache/impala/authorization/BaseAuthorizationChecker.java@158 PS5, Line 158: // we call InsertStmt#analyze(), which in turn registers column-level INSERT : // privilege requests. > Can you turn this into a constant of ImmutableSet? Sure. I will turn this into an a constant of ImmutableSet in patch set 7. http://gerrit.cloudera.org:8080/#/c/23569/5/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/23569/5/tests/authorization/test_ranger.py@1509 PS5, Line 1509: .format(unique_database, unique_table, columns[0], columns[1])) : : # Grant the INSERT privilege on the table to 'grantee_user'. : admin_client.execute("grant insert on table {0}.{1} to user {2}" : .format(unique_database, unique_table, grantee_user)) : # Add a deny policy on 'columns[0]' to prevent 'grantee_user' from inserting data : # into this column. : TestRanger._add_deny_policy(unique_name, grantee_user, unique_database, : unique_table, columns[0], "update") : admin_client.execute(" > Can you add comments on these test steps? Thanks Riza! I will add more code comment in patch set 7. Hopefully it will be clearer. -- To view, visit http://gerrit.cloudera.org:8080/23569 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2ef61801d3b394c56702b193c250492a62b111df Gerrit-Change-Number: 23569 Gerrit-PatchSet: 7 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 06 Nov 2025 19:32:49 +0000 Gerrit-HasComments: Yes
