Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23628 )

Change subject: Generate parallel data load with batch files
......................................................................


Patch Set 5:

(3 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/23628/5/testdata/bin/create-load-data.sh
File testdata/bin/create-load-data.sh:

http://gerrit.cloudera.org:8080/#/c/23628/5/testdata/bin/create-load-data.sh@627
PS5, Line 627:     run-step-backgroundable "Loading dependent tables" 
copy-and-load-dependent-tables.log \
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/23628/5/testdata/bin/generate-schema-statements.py
File testdata/bin/generate-schema-statements.py:

http://gerrit.cloudera.org:8080/#/c/23628/5/testdata/bin/generate-schema-statements.py@758
PS5, Line 758: +
flake8: E226 missing whitespace around arithmetic operator


http://gerrit.cloudera.org:8080/#/c/23628/5/testdata/bin/generate-schema-statements.py@766
PS5, Line 766: d
flake8: E306 expected 1 blank line before a nested definition, found 0



--
To view, visit http://gerrit.cloudera.org:8080/23628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9586504f6cb91f873f7ed978fda3df32e759ba90
Gerrit-Change-Number: 23628
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Comment-Date: Wed, 05 Nov 2025 00:29:20 +0000
Gerrit-HasComments: Yes

Reply via email to