Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23626 )
Change subject: Load testdata with Impala ...................................................................... Patch Set 5: (6 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23626/5/bin/load-data.py File bin/load-data.py: http://gerrit.cloudera.org:8080/#/c/23626/5/bin/load-data.py@262 PS5, Line 262: def copy_workload_data_to_hdfs(workload): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/23626/5/bin/load-data.py@274 PS5, Line 274: ) flake8: E501 line too long (91 > 90 characters) http://gerrit.cloudera.org:8080/#/c/23626/5/testdata/bin/create-hbase.sh File testdata/bin/create-hbase.sh: http://gerrit.cloudera.org:8080/#/c/23626/5/testdata/bin/create-hbase.sh@26 PS5, Line 26: yes exit | $HBASE_HOME/bin/hbase shell $IMPALA_HOME/testdata/data/HBaseAllTypesError/functional_hbase.hbasealltypeserror.hbase line too long (126 > 90) http://gerrit.cloudera.org:8080/#/c/23626/5/testdata/bin/create-hbase.sh@27 PS5, Line 27: yes exit | $HBASE_HOME/bin/hbase shell $IMPALA_HOME/testdata/data/HBaseAllTypesErrorNoNulls/functional_hbase.hbasealltypeserrornonulls.hbase line too long (140 > 90) http://gerrit.cloudera.org:8080/#/c/23626/5/testdata/common/text_delims_table.py File testdata/common/text_delims_table.py: http://gerrit.cloudera.org:8080/#/c/23626/5/testdata/common/text_delims_table.py@68 PS5, Line 68: flake8: E211 whitespace before '(' http://gerrit.cloudera.org:8080/#/c/23626/5/testdata/common/widetable.py File testdata/common/widetable.py: http://gerrit.cloudera.org:8080/#/c/23626/5/testdata/common/widetable.py@140 PS5, Line 140: flake8: E211 whitespace before '(' -- To view, visit http://gerrit.cloudera.org:8080/23626 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I43d681a89d49fde9562ea67fd250fad2edd308ae Gerrit-Change-Number: 23626 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 05 Nov 2025 00:19:57 +0000 Gerrit-HasComments: Yes
