Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/23596 )
Change subject: IMPALA-14501: (Addendum) Fix single node perf run ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/23596/1/bin/single_node_perf_run.py File bin/single_node_perf_run.py: http://gerrit.cloudera.org:8080/#/c/23596/1/bin/single_node_perf_run.py@179 PS1, Line 179: sh.cat(result, _out=sys.stdout) Not your change: I think this command may be failing with this: 14:15:59 Exception in thread Thread-30: 14:15:59 Traceback (most recent call last): 14:15:59 File "/home/ubuntu/Impala/toolchain/toolchain-packages-gcc10.4.0/python-3.8.18/lib/python3.8/threading.py", line 932, in _bootstrap_inner 14:15:59 self.run() 14:15:59 File "/home/ubuntu/Impala/toolchain/toolchain-packages-gcc10.4.0/python-3.8.18/lib/python3.8/threading.py", line 870, in run 14:15:59 self._target(*self._args, **self._kwargs) 14:15:59 File "/home/ubuntu/Impala/infra/python/env-gcc10.4.0-py3/lib/python3.8/site-packages/sh.py", line 1484, in output_thread 14:15:59 done = stream.read() 14:15:59 File "/home/ubuntu/Impala/infra/python/env-gcc10.4.0-py3/lib/python3.8/site-packages/sh.py", line 1974, in read 14:15:59 self.write_chunk(chunk) 14:15:59 File "/home/ubuntu/Impala/infra/python/env-gcc10.4.0-py3/lib/python3.8/site-packages/sh.py", line 1949, in write_chunk 14:15:59 self.should_quit = self.process_chunk(chunk) 14:15:59 File "/home/ubuntu/Impala/infra/python/env-gcc10.4.0-py3/lib/python3.8/site-packages/sh.py", line 1847, in process 14:15:59 handler.write(chunk) 14:15:59 TypeError: write() argument must be str, not bytes It only writes the report out to the console, so it isn't a blocker. -- To view, visit http://gerrit.cloudera.org:8080/23596 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibd815e7eb989d7a2bcf52cadfcde4f355c18a148 Gerrit-Change-Number: 23596 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Sat, 25 Oct 2025 00:01:49 +0000 Gerrit-HasComments: Yes
