Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22865 )
Change subject: IMPALA-13869: Support for 'hive.sql.query' property for Hive JDBC tables ...................................................................... Patch Set 17: (15 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22865/17/fe/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java File fe/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java: http://gerrit.cloudera.org:8080/#/c/22865/17/fe/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java@355 PS17, Line 355: // Make jdbc table name to be quoted with double quotes if columnMapping is not empty line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22865/17/tests/custom_cluster/test_ext_data_sources.py File tests/custom_cluster/test_ext_data_sources.py: http://gerrit.cloudera.org:8080/#/c/22865/17/tests/custom_cluster/test_ext_data_sources.py@177 PS17, Line 177: class TestPostgresJdbcTables(CustomClusterTestSuite): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/22865/17/tests/custom_cluster/test_ext_data_sources.py@343 PS17, Line 343: + flake8: E226 missing whitespace around arithmetic operator http://gerrit.cloudera.org:8080/#/c/22865/17/tests/custom_cluster/test_ext_data_sources.py@349 PS17, Line 349: + flake8: E226 missing whitespace around arithmetic operator http://gerrit.cloudera.org:8080/#/c/22865/17/tests/custom_cluster/test_ext_data_sources.py@352 PS17, Line 352: t flake8: F821 undefined name 'traceback' http://gerrit.cloudera.org:8080/#/c/22865/17/tests/custom_cluster/test_ext_data_sources.py@355 PS17, Line 355: ) flake8: E501 line too long (91 > 90 characters) http://gerrit.cloudera.org:8080/#/c/22865/17/tests/custom_cluster/test_ext_data_sources.py@356 PS17, Line 356: d flake8: E501 line too long (100 > 90 characters) http://gerrit.cloudera.org:8080/#/c/22865/17/tests/custom_cluster/test_ext_data_sources.py@357 PS17, Line 357: a flake8: E501 line too long (97 > 90 characters) http://gerrit.cloudera.org:8080/#/c/22865/17/tests/custom_cluster/test_ext_data_sources.py@358 PS17, Line 358: n flake8: E501 line too long (106 > 90 characters) http://gerrit.cloudera.org:8080/#/c/22865/17/tests/custom_cluster/test_ext_data_sources.py@360 PS17, Line 360: a flake8: E501 line too long (95 > 90 characters) http://gerrit.cloudera.org:8080/#/c/22865/17/tests/custom_cluster/test_ext_data_sources.py@361 PS17, Line 361: s flake8: E501 line too long (93 > 90 characters) http://gerrit.cloudera.org:8080/#/c/22865/17/tests/custom_cluster/test_ext_data_sources.py@363 PS17, Line 363: v flake8: U100 Unused argument 'vector' http://gerrit.cloudera.org:8080/#/c/22865/17/tests/custom_cluster/test_ext_data_sources.py@574 PS17, Line 574: v flake8: U100 Unused argument 'vector' http://gerrit.cloudera.org:8080/#/c/22865/17/tests/custom_cluster/test_ext_data_sources.py@829 PS17, Line 829: v flake8: U100 Unused argument 'vector' http://gerrit.cloudera.org:8080/#/c/22865/17/tests/custom_cluster/test_ext_data_sources.py@831 PS17, Line 831: r flake8: E501 line too long (93 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/22865 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I039fcc1e008233a3eeed8d09554195fdb8c8706b Gerrit-Change-Number: 22865 Gerrit-PatchSet: 17 Gerrit-Owner: Pranav Lodha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Thu, 23 Oct 2025 04:53:43 +0000 Gerrit-HasComments: Yes
