Riza Suminto has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23580 )

Change subject: IMPALA-14509: Let Ozone set OZONE_OPTS
......................................................................


Patch Set 1: Code-Review+2

Confirmed that ozone-1.4.0.7.3.1.500-30/libexec/ozone-functions.sh has this 
function:

## @description  Adds default GC parameters
## @description  Only for server components and only if no other -XX parameters
## @description  are set
## @audience     private
## @stability    evolving
## @replaceable  yes
function ozone_add_default_gc_opts
{
  java_major_version=$(ozone_get_java_major_version)
  if [[ "${OZONE_SUBCMD_SUPPORTDAEMONIZATION}" == true ]]; then
    if [[ ! "$OZONE_OPTS" =~ "-XX" ]] ; then
      OZONE_OPTS="${OZONE_OPTS} -XX:ParallelGCThreads=8"
      if [[ "$java_major_version" -lt 15 ]]; then
        OZONE_OPTS="${OZONE_OPTS} -XX:+UseConcMarkSweepGC 
-XX:CMSInitiatingOccupancyFraction=70 -XX:+CMSParallelRemarkEnabled"
        ozone_error "No '-XX:...' jvm parameters are set. Adding safer GC 
settings '-XX:ParallelGCThreads=8 -XX:+UseConcMarkSweepGC 
-XX:CMSInitiatingOccupancyFraction=70 -XX:+CMSParallelRemarkEnabled' to the 
OZONE_OPTS"
      else
        ozone_error "No '-XX:...' jvm parameters are set. Adding safer GC 
settings '-XX:ParallelGCThreads=8' to the OZONE_OPTS"
      fi
    fi
  fi
}


--
To view, visit http://gerrit.cloudera.org:8080/23580
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If600dd160e6bc72320081ecee2cb0de3c73eb7bd
Gerrit-Change-Number: 23580
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Comment-Date: Thu, 23 Oct 2025 04:04:21 +0000
Gerrit-HasComments: No

Reply via email to