Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/23536 )
Change subject: IMPALA-13066: Extend SHOW CREATE TABLE to include stats and partitions ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/23536/3/fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java File fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java: http://gerrit.cloudera.org:8080/#/c/23536/3/fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java@571 PS3, Line 571: kuduParamsSql, new Pair<>(innerStmt.getSortColumns(), : innerStmt.getSortingOrder()), properties, innerStmt.getSerdeProperties(), : innerStmt.isExternal(), innerStmt.ge > This can have potential scale issue if a table has thousands of partitions, Thanks for your input Quanlong, yes we were a bit confused about the requirements of this jira. I'll be using queries of this form now, correct me if there could be any issues. SHOW CREATE TABLE `sales_data` WITH STATS; (default=1000) SHOW CREATE TABLE sales_data WITH STATS PARTITION_LIMIT=n; http://gerrit.cloudera.org:8080/#/c/23536/6/fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java File fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java: http://gerrit.cloudera.org:8080/#/c/23536/6/fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java@134 PS6, Line 134: props.remove(StatsSetupConst.DO_NOT_UPDATE_STATS); : : // Hide properties that are materialized elsewhere in DDL : removeHiddenTableProperties(props); : : // Table-format specific filtering : if (table instanceof FeKuduTable) { > Done These properties are kept hidden from the user in HIDDEN_TABLE_PROPERTIES but I can make them visible if you insist -- To view, visit http://gerrit.cloudera.org:8080/23536 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I87950ae9d9bb73cb2a435cf5bcad076df1570dc2 Gerrit-Change-Number: 23536 Gerrit-PatchSet: 7 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 21 Oct 2025 15:07:07 +0000 Gerrit-HasComments: Yes
