Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23513 )
Change subject: IMPALA-13695: Calcite planner: fix for ndv with 2 args ...................................................................... Patch Set 4: (1 comment) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23513/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAggRel.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAggRel.java: http://gerrit.cloudera.org:8080/#/c/23513/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAggRel.java@358 PS4, Line 358: Function fn = FunctionResolver.getExactFunction(aggFunction.getName(), aggFunction.getKind(), line too long (97 > 90) -- To view, visit http://gerrit.cloudera.org:8080/23513 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I82419f77e043e9975865a042ffb8db75a26931f7 Gerrit-Change-Number: 23513 Gerrit-PatchSet: 4 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Mon, 20 Oct 2025 16:22:31 +0000 Gerrit-HasComments: Yes
