Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23495 )
Change subject: IMPALA-14473: Fix absolute path logic for sorting scan ranges oldest to newest ...................................................................... IMPALA-14473: Fix absolute path logic for sorting scan ranges oldest to newest When IMPALA-14462 added tie-breaking logic to ScanRangeOldestToNewestComparator, it relied on absolute path being unset if the relative path is set. However, the code always sets absolute path and uses an empty string to indicate whether it is set. This caused the tie-breaking logic to see two unrelated scan ranges as equal, triggering a DCHECK when running query_test/test_tuple_cache_tpc_queries.py. The fix is to rearrange the logic to check whether the relative path is not empty rather than checking whether the absolute path is set. Testing: - Ran query_test/test_tuple_cache_tpc_queries.py - Ran custom_cluster/test_tuple_cache.py Change-Id: I449308f4a0efdca7fc238e3dda24985a2931dd37 Reviewed-on: http://gerrit.cloudera.org:8080/23495 Reviewed-by: Michael Smith <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> Reviewed-by: Yida Wu <[email protected]> Reviewed-by: Joe McDonnell <[email protected]> --- M be/src/scheduling/scheduler.cc 1 file changed, 16 insertions(+), 7 deletions(-) Approvals: Michael Smith: Looks good to me, but someone else must approve Impala Public Jenkins: Verified Yida Wu: Looks good to me, but someone else must approve Joe McDonnell: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/23495 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I449308f4a0efdca7fc238e3dda24985a2931dd37 Gerrit-Change-Number: 23495 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]>
