Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23475 )
Change subject: IMPALA-14467: Support quoted keys with dots in get_json_object path strings ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/23475/1/be/src/exprs/string-functions.cc File be/src/exprs/string-functions.cc: http://gerrit.cloudera.org:8080/#/c/23475/1/be/src/exprs/string-functions.cc@365 PS1, Line 365: int offset = ParseQuotedString(reinterpret_cast<const char*>(path + i), > line has trailing whitespace Done http://gerrit.cloudera.org:8080/#/c/23475/1/be/src/exprs/string-functions.cc@366 PS1, Line 366: reinterpret_cast<const char*>(path_end), > line has trailing whitespace Done http://gerrit.cloudera.org:8080/#/c/23475/1/be/src/util/string-util.cc File be/src/util/string-util.cc: http://gerrit.cloudera.org:8080/#/c/23475/1/be/src/util/string-util.cc@95 PS1, Line 95: int ParseQuotedString(const char* start, const char* end, char quote_char, > line too long (97 > 90) Done -- To view, visit http://gerrit.cloudera.org:8080/23475 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia3618d9e029501f9ac0e23190feb8263968b1b9f Gerrit-Change-Number: 23475 Gerrit-PatchSet: 2 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Thu, 09 Oct 2025 02:36:13 +0000 Gerrit-HasComments: Yes
