Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23457 )
Change subject: IMPALA-14287: Resolve environment variables in REST server configurations ...................................................................... Patch Set 4: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/23457/4/fe/src/main/java/org/apache/impala/service/catalogmanager/ConfigLoader.java File fe/src/main/java/org/apache/impala/service/catalogmanager/ConfigLoader.java: http://gerrit.cloudera.org:8080/#/c/23457/4/fe/src/main/java/org/apache/impala/service/catalogmanager/ConfigLoader.java@112 PS4, Line 112: matcher.appendReplacement(sb, Matcher.quoteReplacement(replacement)); It appears this is doing the work of direct string replacement. quoteReplacement prevents injecting new properties. -- To view, visit http://gerrit.cloudera.org:8080/23457 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3faccc15d012c389703c58371a4d38cca82bef60 Gerrit-Change-Number: 23457 Gerrit-PatchSet: 4 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 06 Oct 2025 19:01:43 +0000 Gerrit-HasComments: Yes
