Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23547 )
Change subject: IMPALA-14502: Not tracking metrics in IncompleteTable ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/23547/2/fe/src/main/java/org/apache/impala/catalog/IncompleteTable.java File fe/src/main/java/org/apache/impala/catalog/IncompleteTable.java: http://gerrit.cloudera.org:8080/#/c/23547/2/fe/src/main/java/org/apache/impala/catalog/IncompleteTable.java@221 PS2, Line 221: /** : * Noop to save memory space. : */ : @Override : public void initMetrics() {} Table.java has some other methods accessing metrics_ like below. Should they be overiden as well by, say, throwing UnimplementedException? public long getMedianTableLoadingTime() { return (long)metrics_.getTimer(LOAD_DURATION_METRIC).getSnapshot().getMedian(); } public long getMaxTableLoadingTime() { return metrics_.getTimer(LOAD_DURATION_METRIC).getSnapshot().getMax(); } public long get75TableLoadingTime() { return (long)metrics_.getTimer(LOAD_DURATION_METRIC). getSnapshot().get75thPercentile(); } public long get95TableLoadingTime() { return (long)metrics_.getTimer(LOAD_DURATION_METRIC). getSnapshot().get95thPercentile(); } public long get99TableLoadingTime() { return (long)metrics_.getTimer(LOAD_DURATION_METRIC). getSnapshot().get99thPercentile(); } public long getTableLoadingCounts() { return metrics_.getTimer(LOAD_DURATION_METRIC).getCount(); } public Metrics getMetrics() { return metrics_; } public void updateHMSLoadTableSchemaTime(long hmsLoadTimeNS) { this.metrics_.getTimer(Table.HMS_LOAD_TBL_SCHEMA). update(hmsLoadTimeNS, TimeUnit.NANOSECONDS); } public boolean removeFromVersionsForInflightEvents( boolean isInsertEvent, long versionNumber) { ... metrics_.getCounter(NUMBER_OF_INFLIGHT_EVENTS).dec(); ... } public boolean addToVersionsForInflightEvents( boolean isInsertEvent, long versionNumber) { ... metrics_.getCounter(NUMBER_OF_INFLIGHT_EVENTS).inc(); ... } -- To view, visit http://gerrit.cloudera.org:8080/23547 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If0fcfeab99bbfbefe618d0abf7f2482a0cc5ef9f Gerrit-Change-Number: 23547 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 16 Oct 2025 14:18:22 +0000 Gerrit-HasComments: Yes
