Xuebin Su has posted comments on this change. ( http://gerrit.cloudera.org:8080/23493 )
Change subject: IMPALA-14472: Add create/read support for ARRAY column of Kudu ...................................................................... Patch Set 7: (4 comments) Thanks for reviewing! http://gerrit.cloudera.org:8080/#/c/23493/4/be/src/exec/kudu/kudu-scanner.cc File be/src/exec/kudu/kudu-scanner.cc: http://gerrit.cloudera.org:8080/#/c/23493/4/be/src/exec/kudu/kudu-scanner.cc@537 PS4, Line 537: > This memory gets deepcopied again on line 551 for surviving rows, so is not Thanks! The new Patch Set tries to reuse the buffer instead of allocating a new one for each CollectionValue. And the buffer will be freed at the end of this function instead of being attached to the row batch. http://gerrit.cloudera.org:8080/#/c/23493/5/be/src/exec/kudu/kudu-scanner.cc File be/src/exec/kudu/kudu-scanner.cc: http://gerrit.cloudera.org:8080/#/c/23493/5/be/src/exec/kudu/kudu-scanner.cc@400 PS5, Line 400: RawValue::WriteNonNull<false>(&tv, kudu_tuple, slot, nullptr, nullptr, nullptr); > Could use writeNotNull() here if you make it public. Thanks! Changed. http://gerrit.cloudera.org:8080/#/c/23493/5/be/src/exec/kudu/kudu-scanner.cc@476 PS5, Line 476: "Could not allocate memory when reading Kudu ARRAY in table '$0' column '$1'", > Is this zeroing needed? IF so, we should make just zero trailing bytes and Thanks! I think I still need more time to think about whether it is needed. http://gerrit.cloudera.org:8080/#/c/23493/5/fe/src/main/java/org/apache/impala/catalog/KuduColumn.java File fe/src/main/java/org/apache/impala/catalog/KuduColumn.java: http://gerrit.cloudera.org:8080/#/c/23493/5/fe/src/main/java/org/apache/impala/catalog/KuduColumn.java@89 PS5, Line 89: Type type = KuduUtil.toImpalaType(colSchema); > Move this into the conditional branch below. Thanks! It seems that 'type' is also used in the return statement below. -- To view, visit http://gerrit.cloudera.org:8080/23493 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9282aac821bd30668189f84b2ed8fff7047e7310 Gerrit-Change-Number: 23493 Gerrit-PatchSet: 7 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Thu, 16 Oct 2025 07:45:50 +0000 Gerrit-HasComments: Yes
