Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23499 )
Change subject: IMPALA-14460: Implement connect_timeout_ms for HS2-HTTP ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/23499/5/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/23499/5/tests/shell/test_shell_commandline.py@1413 PS5, Line 1413: # used for the initial connection, subsequent setTimeout(0) seems to have no effect. With setTimeout(0.0), the socket becomes non-blocking. For the initial connection we don't have retry, and it fails. With RPCs, we have retry on OpenSession, so ii usually fails the 1st time then succeeds on retry after non-zero time has passed. http://gerrit.cloudera.org:8080/#/c/23499/5/tests/shell/test_shell_commandline.py@1432 PS5, Line 1432: expected_err_py3_open = \ I don't understand why sometimes OpenSession succeeds. settimeout reports granularity of 1ns, but I think the OS (I'm running Ubuntu in a VM on macOS) may be more like 1ms given this was a failure with retry (with http_socket_timeout_s=0.0000000009) I20251009 15:36:14.622849 184127 TAcceptQueueServer.cpp:368] New connection to server hiveserver2-http-frontend from client <Host: 127.0.0.1 Port: 36086> I20251009 15:36:14.624032 186198 impala-hs2-server.cc:327] Opening session: ad43b3434501917c:c241a85b14c91f80 request username: msmith2 I20251009 15:36:14.624378 184127 TAcceptQueueServer.cpp:368] New connection to server hiveserver2-http-frontend from client <Host: 127.0.0.1 Port: 36094> I20251009 15:36:14.624611 186198 impala-hs2-server.cc:474] Opened session: ad43b3434501917c:c241a85b14c91f80, effective username: msmith2, client address: <127.0.0.1:36086>. and this succeeded on the first attempt I20251009 15:36:46.845984 184127 TAcceptQueueServer.cpp:368] New connection to server hiveserver2-http-frontend from client <Host: 127.0.0.1 Port: 34986> I20251009 15:36:46.846246 186252 impala-hs2-server.cc:327] Opening session: 6e4f0ca54158914c:cf61571d2366c283 request username: msmith2 I20251009 15:36:46.846351 186252 impala-hs2-server.cc:474] Opened session: 6e4f0ca54158914c:cf61571d2366c283, effective username: msmith2, client address: <127.0.0.1:34986>. I need to do some more testing to see if any of the old messages still apply. -- To view, visit http://gerrit.cloudera.org:8080/23499 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9012066fb0d16497f309532021d7b323404b9fb2 Gerrit-Change-Number: 23499 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Thu, 09 Oct 2025 22:41:08 +0000 Gerrit-HasComments: Yes
