Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23436 )
Change subject: IMPALA-14447: Parallelize table loading in getMissingTables() ...................................................................... Patch Set 18: (4 comments) http://gerrit.cloudera.org:8080/#/c/23436/16/be/src/util/backend-gflag-util.cc File be/src/util/backend-gflag-util.cc: http://gerrit.cloudera.org:8080/#/c/23436/16/be/src/util/backend-gflag-util.cc@369 PS16, Line 369: DEFINE_validator(tuple_cache_cost_coefficient_read_rows, &ValidateNonnegativeDouble); > Nit: Could consider a validator or bounding settings but we don't seem to d Done http://gerrit.cloudera.org:8080/#/c/23436/16/fe/src/main/java/org/apache/impala/analysis/StmtMetadataLoader.java File fe/src/main/java/org/apache/impala/analysis/StmtMetadataLoader.java: http://gerrit.cloudera.org:8080/#/c/23436/16/fe/src/main/java/org/apache/impala/analysis/StmtMetadataLoader.java@368 PS16, Line 368: String queryIdStr = : queryId_ == null ? "<unknown_query_id>" : TUniqueIdUtil.PrintId(queryId_); : L > nit: do you want it to be in TRACE level or DEBUG level? We check isTraceEn Done http://gerrit.cloudera.org:8080/#/c/23436/16/fe/src/main/java/org/apache/impala/analysis/StmtMetadataLoader.java@409 PS16, Line 409: ly { > nit: "ForkJoinPool" is stale Done http://gerrit.cloudera.org:8080/#/c/23436/16/fe/src/main/java/org/apache/impala/analysis/StmtMetadataLoader.java@436 PS16, Line 436: } else { > We don't need multi-threads here in the legacy catalog mode where the local Done -- To view, visit http://gerrit.cloudera.org:8080/23436 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I97a5165844ae846b28338d62e93a20121488d79f Gerrit-Change-Number: 23436 Gerrit-PatchSet: 18 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Mon, 13 Oct 2025 03:29:02 +0000 Gerrit-HasComments: Yes
