Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23470 )
Change subject: IMPALA-14468: Don't genereate errors during InitWorkloadManagement() when everything goes fine ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/23470/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23470/1//COMMIT_MSG@18 PS1, Line 18: Instead of calling ResetMetadata() we can test the existence of the : workload management tables (sys.impala_query_log and : sys.impala_query_live) first. I'm not sure how this will interact with Catalog initialization. In HA context, we recently change the way Catalog reset and serve request through IMPALA-13850 and IMPALA-14220. And issuing RestMetadata seems the safest way to not overlap the table lookup with initial Catalog reset. Can you also check that this new patch still work in Catalog HA? http://gerrit.cloudera.org:8080/#/c/23470/1//COMMIT_MSG@23 PS1, Line 23: * tested manually that the error logs disappear How is this tested? Are you running existing unit test or manually start impala cluster with WM flag enabled? Please try run some exiting tests like: ./tests/custom_cluster/test_workload_mgmt_init.py ./tests/custom_cluster/test_workload_mgmt_sql_details.py -- To view, visit http://gerrit.cloudera.org:8080/23470 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic7f7c92bda57d9fdc2185bf4ef8fd4f09aea0879 Gerrit-Change-Number: 23470 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Fri, 26 Sep 2025 15:37:57 +0000 Gerrit-HasComments: Yes
