Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/23318 )
Change subject: IMPALA-14105: Calcite planner: Runtime filters not being applied with outer joins ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/23318/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaJoinRel.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaJoinRel.java: http://gerrit.cloudera.org:8080/#/c/23318/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaJoinRel.java@492 PS2, Line 492: joinOp == JoinOperator.FULL_OUTER_JOIN)) { > If I remember correctly while coding this, I did run into that "line 2" so I am good with letting the inner code handle it (in the analyzer) and keep the FOJ check here. But in that case, I would go back to my first comment about using the registerFullOuterJoinedTids() instead of registerOuterJoinedTids(). Although FOJ is skipped by the inner code when building the value transfer graph, in terms of code consistency it would be good if the right structures were populated. By calling the registerFullOuterJoinedTids() the correct hashmap fullOuterJoinedTupleIds [3] gets populated, whereas if you call the other method, a different hashmap is populated. [3] https://github.com/apache/impala/blob/master/fe/src/main/java/org/apache/impala/analysis/Analyzer.java#L522 -- To view, visit http://gerrit.cloudera.org:8080/23318 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e06d3f35a10f35ff8b57ba25dbab1bc6a35238a Gerrit-Change-Number: 23318 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin <scar...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Steve Carlin <scar...@cloudera.com> Gerrit-Comment-Date: Tue, 23 Sep 2025 20:33:14 +0000 Gerrit-HasComments: Yes
