Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/23112 )
Change subject: IMPALA-13661: Support parallelism above JDBC tables for joins/aggregates ...................................................................... Patch Set 12: (2 comments) please rebase to avoid merge conflict http://gerrit.cloudera.org:8080/#/c/23112/12/fe/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java File fe/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java: http://gerrit.cloudera.org:8080/#/c/23112/12/fe/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java@134 PS12, Line 134: try { keep indent consistent with previous line. http://gerrit.cloudera.org:8080/#/c/23112/12/fe/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java@139 PS12, Line 139: LOG.error(String.format("Failed to retrieve total number of records: %s", e)); the function should return error status -- To view, visit http://gerrit.cloudera.org:8080/23112 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If47d29bdda5b17a1b369440f04d4e209d12133d9 Gerrit-Change-Number: 23112 Gerrit-PatchSet: 12 Gerrit-Owner: Pranav Lodha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Fri, 19 Sep 2025 21:13:33 +0000 Gerrit-HasComments: Yes
