Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/23264 )
Change subject: IMPALA-14271: Reapply the core piece of IMPALA-6984 ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/23264/3/be/src/runtime/coordinator-backend-state.cc File be/src/runtime/coordinator-backend-state.cc: http://gerrit.cloudera.org:8080/#/c/23264/3/be/src/runtime/coordinator-backend-state.cc@708 PS3, Line 708: *request.mutable_query_id() = query_id_; > query_id_ is const, so shouldn't be modified after constructor. Same with q Yes, and the header file has a list of fields protected by this lock. This chunk of code where we don't hold the lock doesn't reference any of them. -- To view, visit http://gerrit.cloudera.org:8080/23264 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia058b03c72cc4bb83b0bd0a19ff6c8c43a647974 Gerrit-Change-Number: 23264 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Fri, 19 Sep 2025 20:13:40 +0000 Gerrit-HasComments: Yes
