Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/23438 )
Change subject: IMPALA-14451: Log if memory-based admission is skipped ...................................................................... Patch Set 2: (1 comment) Thanks for the comments! http://gerrit.cloudera.org:8080/#/c/23438/1/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/23438/1/be/src/scheduling/admission-controller.cc@1059 PS1, Line 1059: Pool '$0' doesn't have Max Memory configured, therefore " : "Impala skips memory-based query admission. This can result in query failures " : "due to memory exhaustion, therefore we h > Is it impala.admission-control.max-query-mem-limit.<pool_name>? No, we refer to it as "Max Memory" in our docs, and it can be set in fair-scheduler.xml in tags <maxResources>2500 mb</maxResources>. Please note that you can also set other resources there, e.g. <maxResources>128 mb, 1 vcores</maxResources>. I think I'll just refer to it as "Max Memory", as this is what we use in our docs. impala.admission-control.max-query-mem-limit is different, it is for setting a per-host max memory limit for queries. > Also better to use stronger language to set it to concrete value instead of > -1 (ignore). Updated the message, but feel free to recommend a different one. -- To view, visit http://gerrit.cloudera.org:8080/23438 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib98482abc0fbcb53552adfd89cf6d157b17527fd Gerrit-Change-Number: 23438 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 19 Sep 2025 15:33:13 +0000 Gerrit-HasComments: Yes
