Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23436 )
Change subject: IMPALA-14447: Parallelize table loading in getMissingTables() ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/23436/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23436/1//COMMIT_MSG@11 PS1, Line 11: incurr nit: incur http://gerrit.cloudera.org:8080/#/c/23436/1/fe/src/main/java/org/apache/impala/analysis/StmtMetadataLoader.java File fe/src/main/java/org/apache/impala/analysis/StmtMetadataLoader.java: http://gerrit.cloudera.org:8080/#/c/23436/1/fe/src/main/java/org/apache/impala/analysis/StmtMetadataLoader.java@336 PS1, Line 336: FeDb db = catalog.getDb(tblName.getDb()); > It's stated that LocalCatalog and any of the related catalog object impleme The thread-safetiness mostly offered by the underlying MetaProvider. However, we can slightly improve some method, like making LocalCatalog.loadDbs() more resilient towards concurrent access. https://github.com/apache/impala/blob/591bf48c72d78b27bb2377d58a829424418e0426/fe/src/main/java/org/apache/impala/catalog/local/LocalCatalog.java#L104-L105 -- To view, visit http://gerrit.cloudera.org:8080/23436 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I97a5165844ae846b28338d62e93a20121488d79f Gerrit-Change-Number: 23436 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Thu, 18 Sep 2025 14:30:42 +0000 Gerrit-HasComments: Yes
