Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23432 )
Change subject: IMPALA-14446: Clean up pom.xml ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/23432/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23432/6//COMMIT_MSG@19 PS6, Line 19: Compared before and after with dependency:tree; only difference is that > For which pom.xml files was the dependency:tree output checked? `mvn -f fe`. I should probably do `mvn -f java` to check each subproject. http://gerrit.cloudera.org:8080/#/c/23432/6/java/yarn-extras/pom.xml File java/yarn-extras/pom.xml: http://gerrit.cloudera.org:8080/#/c/23432/6/java/yarn-extras/pom.xml@a79 PS6, Line 79: > Why remove this exclusion? It shouldn't matter either way since log4j shou Because it's no longer part of hadoop-yarn-common, and we have a bannedDependencies check that it's not present. -- To view, visit http://gerrit.cloudera.org:8080/23432 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If96649840e23036b4a73ee23e8d12516497994f0 Gerrit-Change-Number: 23432 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 18 Sep 2025 23:21:32 +0000 Gerrit-HasComments: Yes
