Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23418 )
Change subject: IMPALA-14372: Output OpenTelemetry SDK Logs to Impala Logs ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/23418/4/be/src/observe/otel-log-handler.cc File be/src/observe/otel-log-handler.cc: http://gerrit.cloudera.org:8080/#/c/23418/4/be/src/observe/otel-log-handler.cc@23 PS4, Line 23: #include <opentelemetry/common/attribute_value.h> > I used UNLIKELY here to optimize the most common code path that will be use Isn't that reversed then? This would be the LIKELY branch. http://gerrit.cloudera.org:8080/#/c/23418/4/be/src/observe/otel-log-handler.cc@27 PS4, Line 27: #include "common/compiler-util.h" > Switched to std::stringstream Ack http://gerrit.cloudera.org:8080/#/c/23418/6/be/src/observe/otel-log-handler.cc File be/src/observe/otel-log-handler.cc: http://gerrit.cloudera.org:8080/#/c/23418/6/be/src/observe/otel-log-handler.cc@71 PS6, Line 71: string log_msg = strings::Substitute("$0 file=\"$1\" line=\"$2\"$3", msg, file, line, I'm not sure if this is faster. We could benchmark it. It's probably fine either way, since we're writing to logs right after. -- To view, visit http://gerrit.cloudera.org:8080/23418 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41aba21f46233e6430eede9606be1e791071717a Gerrit-Change-Number: 23418 Gerrit-PatchSet: 6 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 18 Sep 2025 20:29:59 +0000 Gerrit-HasComments: Yes
