Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23228 )
Change subject: IMPALA-13548: Schedule scan ranges oldest to newest for tuple caching ...................................................................... Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/23228/3/be/src/scheduling/scheduler.cc File be/src/scheduling/scheduler.cc: http://gerrit.cloudera.org:8080/#/c/23228/3/be/src/scheduling/scheduler.cc@221 PS3, Line 221: // If we're going to schedule scan ranges oldest to newest, copy it to a separate nit: we could clean up the conditional logic here to something like locations = &entry.second.concrete_ranges; if (!split_specs.empty() || node_schedule_oldest_to_newest) { locations = &expanded_locations; expanded_locations.insert(concrete_ranges); GenerateScanRanges(...) // no-op on empty list } -- To view, visit http://gerrit.cloudera.org:8080/23228 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia4108c7a00c6acf8bbfc036b2b76e7c02ae44d47 Gerrit-Change-Number: 23228 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 18 Sep 2025 18:10:37 +0000 Gerrit-HasComments: Yes
