Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23382 )
Change subject: IMPALA-14400: Fix deadlock in CatalogServiceCatalog.getDbProperty() ...................................................................... Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/23382/7/fe/src/main/java/org/apache/impala/catalog/CatalogResetManager.java File fe/src/main/java/org/apache/impala/catalog/CatalogResetManager.java: http://gerrit.cloudera.org:8080/#/c/23382/7/fe/src/main/java/org/apache/impala/catalog/CatalogResetManager.java@84 PS7, Line 84: private final Queue<Pair<String, Future<PrefetchedDatabaseObjects>>> fetchingDbs_; > Nit: Unless a specific method from the ConcurrentLinkedQueue class is neede Done http://gerrit.cloudera.org:8080/#/c/23382/7/fe/src/main/java/org/apache/impala/catalog/CatalogResetManager.java@98 PS7, Line 98: pendingDbNames_ = new LinkedList<>(); > Mentioned in commit message: Done http://gerrit.cloudera.org:8080/#/c/23382/7/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/23382/7/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@2546 PS7, Line 2546: metastoreEventProcessor_.start(); > If we are starting event processor here after first reset instead of starti I think there are scenario other than EventProcessor that might concurrently calls methods of CatalogServiceCatalog, such as incoming RPC from coordinator when active-standby CatalogD failover is happening/flapping (ie., getPartialCatalogObject()). It should be safe to keep waitInitialResetCompletion(), because in most cases, it should be a no-op when: - triggeredInitialReset_ is false (initial reset already happen), or - resetManager_ is not currently active. -- To view, visit http://gerrit.cloudera.org:8080/23382 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3162472ea9531add77886bf1d0d73460ff34d07a Gerrit-Change-Number: 23382 Gerrit-PatchSet: 8 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 08 Sep 2025 17:11:51 +0000 Gerrit-HasComments: Yes
