Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/23413 )
Change subject: IMPALA-14373: Take ExecState Lock in OpenTelemetry Trace SpanManager ...................................................................... Patch Set 5: (1 comment) Patch is unnecessary, abandoning. http://gerrit.cloudera.org:8080/#/c/23413/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23413/5//COMMIT_MSG@9 PS5, Line 9: According to the documentation in impala-server.h, the : exec_state_lock_ must be held while accessing the ExecState from : ClientRequestState objects > This comment might be stale. In client-request-state.h: Yeah, I believe you are correct holding exec_state_lock_ is not required if ClientRequestState::exec_state() is called to get the ExecState instance. To go further, I see know my understanding of the purpose of 'exec_state_lock_' was incorrect. That mutex is specifically for the `exec_state_cv_` condition variable, not for the 'exec_state_' atomic enum. -- To view, visit http://gerrit.cloudera.org:8080/23413 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica9bb637516c8acfbee77f082b67d725e4cec5d8 Gerrit-Change-Number: 23413 Gerrit-PatchSet: 5 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 17 Sep 2025 21:25:09 +0000 Gerrit-HasComments: Yes
