Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/23431 )
Change subject: IMPALA-14443: Fix potential memory leak in TmpFileMgr ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/23431/1/be/src/runtime/tmp-file-mgr.cc File be/src/runtime/tmp-file-mgr.cc: http://gerrit.cloudera.org:8080/#/c/23431/1/be/src/runtime/tmp-file-mgr.cc@1478 PS1, Line 1478: unique_ptr<TmpFileRemote> tmp_file_r = make_unique<TmpFileRemote>( > Yeah, that would only work with 'new'. Can't we use 'auto' in this case tho I'm not against auto, but based on my experience most Impala contributors prefer explicit types. Also this CR has been merged, I don't think it worth another CR. -- To view, visit http://gerrit.cloudera.org:8080/23431 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a516eab1a946e7368c6059f8d1cc430d2ee19e9 Gerrit-Change-Number: 23431 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 17 Sep 2025 12:17:31 +0000 Gerrit-HasComments: Yes
