Sai Hemanth Gantasala has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23159 )

Change subject: IMPALA-14082: Support batch processing of RELOAD events on same 
table
......................................................................


Patch Set 12:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/23159/11/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:

http://gerrit.cloudera.org:8080/#/c/23159/11/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@7536
PS11, Line 7536:
> nit: add spaces around "-"
Ack


http://gerrit.cloudera.org:8080/#/c/23159/6/tests/custom_cluster/test_events_custom_configs.py
File tests/custom_cluster/test_events_custom_configs.py:

http://gerrit.cloudera.org:8080/#/c/23159/6/tests/custom_cluster/test_events_custom_configs.py@578
PS6, Line 578:     MetaStoreEvents#BatchPartitionEvent and 
BatchPartitionEvent#isOlderEvent() requires
> Please add comments in the code..
Ack


http://gerrit.cloudera.org:8080/#/c/23159/7/tests/custom_cluster/test_events_custom_configs.py
File tests/custom_cluster/test_events_custom_configs.py:

http://gerrit.cloudera.org:8080/#/c/23159/7/tests/custom_cluster/test_events_custom_configs.py@631
PS7, Line 631:     EventProcessorUtils.wait_for_event_processing(self)
> Thanks for digging into this! I think we should be fine to update lastSynce
Created this: https://issues.apache.org/jira/browse/IMPALA-14448



--
To view, visit http://gerrit.cloudera.org:8080/23159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3e9a99b666a1c928ac2a136bded1e5420f77dab
Gerrit-Change-Number: 23159
Gerrit-PatchSet: 12
Gerrit-Owner: Sai Hemanth Gantasala <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]>
Gerrit-Comment-Date: Wed, 17 Sep 2025 04:07:08 +0000
Gerrit-HasComments: Yes

Reply via email to