Mihaly Szjatinya has posted comments on this change. ( http://gerrit.cloudera.org:8080/23394 )
Change subject: IMPALA-14013: DROP INCREMENTAL STATS throws NullPointerException for Iceberg tables ...................................................................... Patch Set 2: (5 comments) Thank you. http://gerrit.cloudera.org:8080/#/c/23394/2/fe/src/main/java/org/apache/impala/analysis/DropStatsStmt.java File fe/src/main/java/org/apache/impala/analysis/DropStatsStmt.java: http://gerrit.cloudera.org:8080/#/c/23394/2/fe/src/main/java/org/apache/impala/analysis/DropStatsStmt.java@114 PS2, Line 114: if (partitionSet_ != null) { > What about merging the two ifs from L113 and L119 (OR) and print a more gen Hmm, I would leave this as is IYDM. It is from ComputeStatsStmt and I can see similar pattern a lot in these files. http://gerrit.cloudera.org:8080/#/c/23394/2/fe/src/main/java/org/apache/impala/analysis/DropStatsStmt.java@115 PS2, Line 115: DROP INCREMENTAL ... > DROP INCREMENTAL STATS ... Ack, fixed also in ComputeStatsStmt http://gerrit.cloudera.org:8080/#/c/23394/2/fe/src/main/java/org/apache/impala/analysis/DropStatsStmt.java@116 PS2, Line 116: non-HDFS > Should be "non-filesystem-based" That's right. Fixed also in ComputeStatsStmt http://gerrit.cloudera.org:8080/#/c/23394/2/fe/src/main/java/org/apache/impala/analysis/DropStatsStmt.java@121 PS2, Line 121: DROP INCREMENTAL ... > DROP INCREMENTAL STATS ... Ack, fixed also in ComputeStatsStmt http://gerrit.cloudera.org:8080/#/c/23394/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-compute-stats.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-compute-stats.test: http://gerrit.cloudera.org:8080/#/c/23394/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-compute-stats.test@391 PS2, Line 391: ---- QUERY : DROP INCREMENTAL STATS ice_alltypes_part PARTITION (i=1); : ---- CATCH : DROP INCREMENTAL ... PARTITION not supported for Iceberg table > Could be an Analyzer test in AnalyzeDDLTest. Done -- To view, visit http://gerrit.cloudera.org:8080/23394 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If3d9ef45a9c9ddce9a5e43c5058ae84f919e0283 Gerrit-Change-Number: 23394 Gerrit-PatchSet: 2 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Comment-Date: Mon, 15 Sep 2025 16:26:40 +0000 Gerrit-HasComments: Yes
