Mihaly Szjatinya has posted comments on this change. ( http://gerrit.cloudera.org:8080/23234 )
Change subject: IMPALA-14282: Workload Management Custom Cluster Tests Use New Utility Functions ...................................................................... Patch Set 5: Code-Review+1 (1 comment) LGTM http://gerrit.cloudera.org:8080/#/c/23234/5/tests/util/workload_management.py File tests/util/workload_management.py: http://gerrit.cloudera.org:8080/#/c/23234/5/tests/util/workload_management.py@202 PS5, Line 202: network_address = re.search(r'\n\s+Network Address:\s+(.*?)\n', profile_text) There are still similar places with direct parsing. Do you plan to cover those as well? -- To view, visit http://gerrit.cloudera.org:8080/23234 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If42a8b5b6fdb43fb2bb37dd2a3be4668e8a5e283 Gerrit-Change-Number: 23234 Gerrit-PatchSet: 5 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 12 Sep 2025 09:44:41 +0000 Gerrit-HasComments: Yes
