Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/23396 )
Change subject: IMPALA-14411: enable_workload_mgmt should work with V2 profile ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/23396/4/tests/custom_cluster/test_workload_mgmt_init.py File tests/custom_cluster/test_workload_mgmt_init.py: http://gerrit.cloudera.org:8080/#/c/23396/4/tests/custom_cluster/test_workload_mgmt_init.py@525 PS4, Line 525: def test_with_experimental_profile(self): This test would be better in the test_query_log.py file since this file is focused on testing Impala cluster startup scenarios (which is when the sys.impala_query_live and sys.impala_query_log tables are created/upgraded). Specifically I recommend placing the test in the 'TestQueryLogTableHS2' class. Is there a jira to add assertions for this test? The regular 'assert_query' function cannot be called since it asserts using data parsed from the profile. -- To view, visit http://gerrit.cloudera.org:8080/23396 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iccb4ad9279b0d66479b1e7816ffc732028e71734 Gerrit-Change-Number: 23396 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 09 Sep 2025 23:23:41 +0000 Gerrit-HasComments: Yes
