Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/23382 )
Change subject: IMPALA-14400: Fix deadlock in CatalogServiceCatalog.getDbProperty() ...................................................................... Patch Set 7: Code-Review+2 (2 comments) Nice touch on using try with resources! Couple of nits, please carry forward +2 if you decide to make any changes. http://gerrit.cloudera.org:8080/#/c/23382/7/fe/src/main/java/org/apache/impala/catalog/CatalogResetManager.java File fe/src/main/java/org/apache/impala/catalog/CatalogResetManager.java: http://gerrit.cloudera.org:8080/#/c/23382/7/fe/src/main/java/org/apache/impala/catalog/CatalogResetManager.java@84 PS7, Line 84: private final ConcurrentLinkedQueue<Pair<String, Future<PrefetchedDatabaseObjects>>> Nit: Unless a specific method from the ConcurrentLinkedQueue class is needed, please keep this variable type as an interface (in this case, Queue<Pair<String, Future<PrefetchedDatabaseObjects>>>). http://gerrit.cloudera.org:8080/#/c/23382/7/fe/src/main/java/org/apache/impala/catalog/CatalogResetManager.java@98 PS7, Line 98: fetchingDbs_ = new ConcurrentLinkedQueue<>(); Nit: I did not see an explanation for the switch from LinkedList to ConcurrentLinkedQueue. -- To view, visit http://gerrit.cloudera.org:8080/23382 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3162472ea9531add77886bf1d0d73460ff34d07a Gerrit-Change-Number: 23382 Gerrit-PatchSet: 7 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 08 Sep 2025 16:58:23 +0000 Gerrit-HasComments: Yes
