Daniel Becker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23334 )
Change subject: IMPALA-14290: Make Iceberg partitioning column names case insensitive ...................................................................... IMPALA-14290: Make Iceberg partitioning column names case insensitive When creating or altering partitions of Iceberg tables, Impala only accepts column names if they are in lowercase and throws ImpalaRuntimeException otherwise. This patch allows the usage of other cases as well in PARTITION SPEC clauses. IcebergPartitionField converts field names to lower case in its constructor, similar to ColumnDef and PartitionKeyValue. Testing: * ran existing tests * add new test with mixed letter case columns Change-Id: I4080a6b7468fff940435e2e780322d4ba1f0de49 Reviewed-on: http://gerrit.cloudera.org:8080/23334 Reviewed-by: Daniel Becker <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M fe/src/main/java/org/apache/impala/analysis/IcebergPartitionField.java M testdata/workloads/functional-query/queries/QueryTest/iceberg-column-case-sensitivity-issue.test 2 files changed, 36 insertions(+), 2 deletions(-) Approvals: Daniel Becker: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/23334 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I4080a6b7468fff940435e2e780322d4ba1f0de49 Gerrit-Change-Number: 23334 Gerrit-PatchSet: 5 Gerrit-Owner: Daniel Vanko <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]>
