Zoltan Borok-Nagy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23156 )

Change subject: IMPALA-14018: Configure OAUTH2 with Lakekeeper and fix Impala's 
config handling
......................................................................


Patch Set 4:

(1 comment)

Thanks for the comments!

http://gerrit.cloudera.org:8080/#/c/23156/4/testdata/bin/minicluster_lakekeeper/docker-compose.yaml
File testdata/bin/minicluster_lakekeeper/docker-compose.yaml:

http://gerrit.cloudera.org:8080/#/c/23156/4/testdata/bin/minicluster_lakekeeper/docker-compose.yaml@104
PS4, Line 104:       test: ["CMD-SHELL", '[ -f /tmp/HealthCheck.java ] || echo 
"public class HealthCheck { public static void main(String[] args) throws 
java.lang.Throwable { java.net.URI uri = java.net.URI.create(args[0]); 
System.exit(java.net.HttpURLConnection.HTTP_OK == 
((java.net.HttpURLConnection)uri.toURL().openConnection()).getResponseCode() ? 
0 : 1); } }" > /tmp/HealthCheck.java && java /tmp/HealthCheck.java 
http://localhost:9000/health/live']
> nit: why not split this into rows?
Done



--
To view, visit http://gerrit.cloudera.org:8080/23156
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie5785cb72773e188b1de7c7924cc6f0b1f96de33
Gerrit-Change-Number: 23156
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <[email protected]>
Gerrit-Reviewer: Daniel Becker <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Mihaly Szjatinya <[email protected]>
Gerrit-Reviewer: Peter Rozsa <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Fri, 05 Sep 2025 14:41:58 +0000
Gerrit-HasComments: Yes

Reply via email to