Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/23164 )
Change subject: IMPALA-13437 (part 1): Compute processing cost before TupleCachePlanner ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/23164/6/fe/src/main/java/org/apache/impala/planner/Planner.java File fe/src/main/java/org/apache/impala/planner/Planner.java: http://gerrit.cloudera.org:8080/#/c/23164/6/fe/src/main/java/org/apache/impala/planner/Planner.java@360 PS6, Line 360: This is true for : // COMPUTE_PROCESSING_COST=true and ENABLE_TUPLE_CACHE=true This is true if COMPUTE_PROCESSING_COST=true or ENABLE_TUPLE_CACHE=true? http://gerrit.cloudera.org:8080/#/c/23164/6/fe/src/main/java/org/apache/impala/planner/TupleCacheInfo.java File fe/src/main/java/org/apache/impala/planner/TupleCacheInfo.java: http://gerrit.cloudera.org:8080/#/c/23164/6/fe/src/main/java/org/apache/impala/planner/TupleCacheInfo.java@567 PS6, Line 567: detailLevel The detailLevel isn't used in this method yet. Is this a placeholder for a future use? http://gerrit.cloudera.org:8080/#/c/23164/6/fe/src/main/java/org/apache/impala/planner/TupleCacheNode.java File fe/src/main/java/org/apache/impala/planner/TupleCacheNode.java: http://gerrit.cloudera.org:8080/#/c/23164/6/fe/src/main/java/org/apache/impala/planner/TupleCacheNode.java@55 PS6, Line 55: if (child.getFilteredCardinality() != cardinality_) { Can we assert that the child.getFilteredCardinality() <= child.getCardinality()? -- To view, visit http://gerrit.cloudera.org:8080/23164 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If78f5d002b0e079eef1eece612f0d4fefde545c7 Gerrit-Change-Number: 23164 Gerrit-PatchSet: 6 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 04 Sep 2025 23:13:41 +0000 Gerrit-HasComments: Yes
