Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23375 )
Change subject: IMPALA-14395: Add -full_s3a option for distribution ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/23375/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23375/1//COMMIT_MSG@9 PS1, Line 9: Adds a -full_s3a build option to use hadoop-aws's full dependencies : instead of the impala-minimal-s3a-aws-sdk jar. This is useful for : distributions that already include the AWS SDK bundle to avoid including : our minimal jar and duplicating its contents. > We would have to enable it in CDP builds, and not during builds destined fo Ack. Looks like this can be a downstream-only patch, but don't mind having this upstream as well. http://gerrit.cloudera.org:8080/#/c/23375/1/java/executor-deps/pom.xml File java/executor-deps/pom.xml: http://gerrit.cloudera.org:8080/#/c/23375/1/java/executor-deps/pom.xml@249 PS1, Line 249: Depend on hadoop-aws dependencies instead of our minimal jar. nit: Please mention that this is only used by downstream Cloudera build. Maybe some line about usage as well: To active this profile, set environment variable 'FULL_S3A' to '1', or use 'mvn package -Pfull-s3a'. -- To view, visit http://gerrit.cloudera.org:8080/23375 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ife5c70322872e42ecf811d550353c8a889f5a341 Gerrit-Change-Number: 23375 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 03 Sep 2025 23:21:12 +0000 Gerrit-HasComments: Yes
