Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21824 )
Change subject: IMPALA-13373: Analytic query with struct from view fails ...................................................................... Patch Set 7: (2 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/21824/7/fe/src/main/java/org/apache/impala/analysis/RecursiveExprSubstitutionMapInserter.java File fe/src/main/java/org/apache/impala/analysis/RecursiveExprSubstitutionMapInserter.java: http://gerrit.cloudera.org:8080/#/c/21824/7/fe/src/main/java/org/apache/impala/analysis/RecursiveExprSubstitutionMapInserter.java@81 PS7, Line 81: // https://github.com/apache/impala/blob/58fd45f20c22f8a062f603d6b96f62ee57d85ca9/fe/src/main/java/org/apache/impala/analysis/Analyzer.java#L1640 line too long (153 > 90) http://gerrit.cloudera.org:8080/#/c/21824/7/fe/src/main/java/org/apache/impala/analysis/RecursiveExprSubstitutionMapInserter.java@88 PS7, Line 88: Preconditions.checkState(baseTableExpr instanceof SlotRef || baseTableExpr == null); line too long (92 > 90) -- To view, visit http://gerrit.cloudera.org:8080/21824 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ecd79ba00396fb557581514462af86f2f450c86 Gerrit-Change-Number: 21824 Gerrit-PatchSet: 7 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 03 Sep 2025 14:04:46 +0000 Gerrit-HasComments: Yes
