Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23371 )
Change subject: IMPALA-14383: Fix crash in casting timestamp string with timezone offsets to DATE ...................................................................... Patch Set 2: (1 comment) Thanks for the quick review! http://gerrit.cloudera.org:8080/#/c/23371/1/be/src/runtime/datetime-simple-date-format-parser.cc File be/src/runtime/datetime-simple-date-format-parser.cc: http://gerrit.cloudera.org:8080/#/c/23371/1/be/src/runtime/datetime-simple-date-format-parser.cc@404 PS1, Line 404: > Actually this could be just "<" because if it were equal, we would go to th Nice catch! -- To view, visit http://gerrit.cloudera.org:8080/23371 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I36d73f4a71432588732b2284ac66552f75628a62 Gerrit-Change-Number: 23371 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 03 Sep 2025 13:27:41 +0000 Gerrit-HasComments: Yes
