Jason Fehr has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23319 )

Change subject: IMPALA-14333: Run impala-py.test using Python3
......................................................................


Patch Set 17:

(1 comment)

> Patch Set 17:
>
> Thank you Michael and Jason for your review!
> I'll rebase this patch later today once IMPALA-13731 and other flaky tests 
> fixes merged.
>
> I'll also need to remind everyone that once this patch merged, Impala will 
> stop testing impala-shell + Python2 combo. If later on we realize it still 
> needed somehow, we can revert the default value of IMPALA_USE_PYTHON3_TESTS 
> back to false in impala-config.sh.

Since Impala shell still supports Python 2, will the Impala Shell release 
process still test on Python 2?

http://gerrit.cloudera.org:8080/#/c/23319/5//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/23319/5//COMMIT_MSG@45
PS5, Line 45:
> Ack.  I also misunderstood this.  Python 2 test dimension will still get ge
Clarification:  Python 2 test dimension will not be created if 
IMPALA_USE_PYTHON3_TESTS=true.



--
To view, visit http://gerrit.cloudera.org:8080/23319
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I401a93b6cc7bcd17f41d24e7a310e0c882a550d4
Gerrit-Change-Number: 23319
Gerrit-PatchSet: 17
Gerrit-Owner: Riza Suminto <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Laszlo Gaal <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Comment-Date: Tue, 02 Sep 2025 19:28:03 +0000
Gerrit-HasComments: Yes

Reply via email to