Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/23363 )
Change subject: IMPALA-14349: Encode FileDescriptors in time in loading Iceberg Tables ...................................................................... Patch Set 1: (2 comments) Thanks for this change! Just a few nits. http://gerrit.cloudera.org:8080/#/c/23363/1/fe/src/main/java/org/apache/impala/catalog/IcebergFileMetadataLoader.java File fe/src/main/java/org/apache/impala/catalog/IcebergFileMetadataLoader.java: http://gerrit.cloudera.org:8080/#/c/23363/1/fe/src/main/java/org/apache/impala/catalog/IcebergFileMetadataLoader.java@138 PS1, Line 138: loadedFds_.add(fd); : fileMetadataStats_.accumulate(fd); : ++loadStats_.loadedFiles; This is now done in three places (here, L129, L163). It could make sense to extract this into a function. If this routine changes in the future, we could forget updating it in all places. http://gerrit.cloudera.org:8080/#/c/23363/1/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java File fe/src/main/java/org/apache/impala/catalog/IcebergTable.java: http://gerrit.cloudera.org:8080/#/c/23363/1/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@517 PS1, Line 517: content files Maybe "content file list" or "content file paths"? First I thought it actually meant loading the file contents. -- To view, visit http://gerrit.cloudera.org:8080/23363 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1c2a7119d76db7ce7c43caec2ccb122a014851b Gerrit-Change-Number: 23363 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 02 Sep 2025 11:55:30 +0000 Gerrit-HasComments: Yes
