Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23279 )
Change subject: IMPALA-13237: [Patch 8] - OpenTelemetry Traces for DML/DDL Queries and Handle Leading Comments ...................................................................... Patch Set 25: (1 comment) http://gerrit.cloudera.org:8080/#/c/23279/25/tests/custom_cluster/test_otel_trace.py File tests/custom_cluster/test_otel_trace.py: http://gerrit.cloudera.org:8080/#/c/23279/25/tests/custom_cluster/test_otel_trace.py@789 PS25, Line 789: : def test_select_comments(self): : """Asserts SQL statements that begin with comments are still traced.""" : queries_success = [ : "-- comment1\nselect 1", : "-- comment1\n select 1", : "-- comment1/*comment2*/\nselect 1", : "-- comment1\n/*comment2*/select 1", : "--comment1\n--comment2\nselect 1", : "--comment1\n --comment2\nselect 1", : "/*comment1*/select 1", : "/*comment1*/ select 1", : "/*comment1*/ /*comment2*/select 1", : "/*comment1*/ select /* inline */ 1", : "/*comment1*/ select /* inline */ 1 /* ending */", : "--comment1\nselect /* inline */ 1 /* ending */", : "--comment1 /*inline*/\nselect /* inline */ 1 /* ending */", : ] : : queries_failure = [ : "/*comment not terminated select 1", : "/*comment1*/ /*comment 2 not terminated select 1", : "/*comment only*/", : "--comment only", : "--comment only\n", : "--comment only\n--comment only 2", : "--comment only\n--comment only 2\n", : ] : : for query in queries_failure: : result = self.execute_query_expect_failure(self.client, query) : : for i, query in enumerate(queries_success): : result = self.execute_query_expect_success(self.client, query) : : self.assert_trace( : query_id=result.query_id, : query_profile=result.runtime_profile, : cluster_id="select_dml", : trace_cnt=i) : : assert count_lines(self.trace_file_path) \ : == self.trace_file_count + len(queries_success) nit: This is already represented by otel-test.cc and can be removed. -- To view, visit http://gerrit.cloudera.org:8080/23279 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie9e83d7f761f3d629f067e0a0602224e42cd7184 Gerrit-Change-Number: 23279 Gerrit-PatchSet: 25 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Fri, 29 Aug 2025 16:22:24 +0000 Gerrit-HasComments: Yes
