Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23343 )
Change subject: IMPALA-14348: Fix TSAN issue after IMPALA-14327 ...................................................................... IMPALA-14348: Fix TSAN issue after IMPALA-14327 IMPALA-14327 reveal TSAN issue in impala-hs2-server.cc. ClientRequestState::returns_result_set() was accessed without holding ClientRequestState::lock_ in impala-hs2-server.cc. This patch fix the issue by obtaining ClientRequestState::lock_ first before accessing ClientRequestState::returns_result_set() and ClientRequestState::result_metadata(). Both accesses are done inside ImpalaServer::SetupResultsCacheing so lock_ only need to be obtained once. Filed IMPALA-14359 to follow up investigation. Testing: Run and pass TSAN build. Change-Id: I41fc25cea5b4ef7b4b9daac54b8665fa76ceb1cd Reviewed-on: http://gerrit.cloudera.org:8080/23343 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/runtime/query-driver.cc M be/src/service/client-request-state.h M be/src/service/impala-hs2-server.cc M be/src/service/impala-server.h 4 files changed, 30 insertions(+), 14 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/23343 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I41fc25cea5b4ef7b4b9daac54b8665fa76ceb1cd Gerrit-Change-Number: 23343 Gerrit-PatchSet: 7 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]>
