Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23345 )
Change subject: IMPALA-14160: Omit compression, encryption, EC in cache key ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/23345/1/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: http://gerrit.cloudera.org:8080/#/c/23345/1/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@2702 PS1, Line 2702: // Ignore file_compression, it does not impact file contents. : scanRange.hdfs_file_split.file_compression = THdfsCompression.NONE; : // Ignore is_encrypted, it does not impact file contents. : scanRange.hdfs_file_split.unsetIs_encrypted(); : // Ignore erasure coding, it does not impact file contents. : scanRange.hdfs_file_split.unsetIs_erasure_coded(); > I am not familiar with the tuple cache - do we consider the size of files? The tuple cache should use the same cache key if the contents of the scan range is the same. I guess one area I'm not sure about that is if the offset and length interact with compression or encryption. -- To view, visit http://gerrit.cloudera.org:8080/23345 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3595003b9e1fbbd95524b196db002b857acd7870 Gerrit-Change-Number: 23345 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 26 Aug 2025 15:42:02 +0000 Gerrit-HasComments: Yes
