Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23337 )
Change subject: IMPALA_14095: Calcite Planner: Use pruned row counts in stats ...................................................................... Patch Set 3: (8 comments) http://gerrit.cloudera.org:8080/#/c/23337/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/util/PrunedPartitionHelper.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/util/PrunedPartitionHelper.java: http://gerrit.cloudera.org:8080/#/c/23337/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/util/PrunedPartitionHelper.java@63 PS2, Line 63: // not final because this is lazy loaded. : private Double prunedRowCount_ > Done Done http://gerrit.cloudera.org:8080/#/c/23337/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/CalciteTable.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/CalciteTable.java: http://gerrit.cloudera.org:8080/#/c/23337/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/CalciteTable.java@101 PS2, Line 101: // Not final due to lazy loading : private HdfsEstimatedMissingTableStats estimatedMissingStats_; : : // The tuple descriptor which is needed by the partition pruner. : private TupleDescriptor tupleDescForPruning_; : : // Output expressions of the tuple descriptor used by the partition pruner : // (just a bunch of SlotRefs) : private List<Expr> outputExprs_ > Init with null for clarity. Done http://gerrit.cloudera.org:8080/#/c/23337/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/CalciteTable.java@240 PS2, Line 240: table_.loadAllPartitio > Yeah, forgot to update this one from your commit request. Done http://gerrit.cloudera.org:8080/#/c/23337/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/CalciteTable.java@287 PS2, Line 287: private TupleDescriptor createTupleAndSlotDes > Done Done http://gerrit.cloudera.org:8080/#/c/23337/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/CalciteTable.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/CalciteTable.java: http://gerrit.cloudera.org:8080/#/c/23337/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/CalciteTable.java@102 PS3, Line 102: private HdfsEstimatedMissingTableStats estimatedMissingStats_; private HdfsEstimatedMissingTableStats estimatedMissingStats_ = null; http://gerrit.cloudera.org:8080/#/c/23337/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/CalciteTable.java@105 PS3, Line 105: private TupleDescriptor tupleDescForPruning_; private TupleDescriptor tupleDescForPruning_ = null; http://gerrit.cloudera.org:8080/#/c/23337/3/java/calcite-planner/src/test/java/org/apache/impala/planner/TestCalciteStats.java File java/calcite-planner/src/test/java/org/apache/impala/planner/TestCalciteStats.java: http://gerrit.cloudera.org:8080/#/c/23337/3/java/calcite-planner/src/test/java/org/apache/impala/planner/TestCalciteStats.java@324 PS3, Line 324: tets nit: tests http://gerrit.cloudera.org:8080/#/c/23337/3/java/calcite-planner/src/test/java/org/apache/impala/planner/TestCalciteStats.java@359 PS3, Line 359: tets nit: tests -- To view, visit http://gerrit.cloudera.org:8080/23337 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I442667a338d30d3daa66e223154bc9a1835b2880 Gerrit-Change-Number: 23337 Gerrit-PatchSet: 3 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Mon, 25 Aug 2025 20:21:57 +0000 Gerrit-HasComments: Yes
