Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23341 )
Change subject: IMPALA-14080: Support LocalFsTable table types in Calcite planner. ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/23341/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/CalciteTable.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/CalciteTable.java: http://gerrit.cloudera.org:8080/#/c/23341/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/CalciteTable.java@102 PS1, Line 102: // TODO: If table_.getNumRows() is unknown (-1), this logic will load all partitions Ack. A couple of notes on this: - We should probably make estimatedMissingStats_ not final, move this to "getNumRows", and only lazily fetch it when it is null. - While we will still fetch all partitions, the follow-up fix to prevent this has been filed for IMPALA-14095. This Jira is for making sure we used the HdfsPartitionPruner to fetch row counts during join optimization. It will only call "getNumRows" if there is no partition pruning...in which case it would fetch all partitions which is similar to what the classic original Impala planner does. So maybe change this TODO to contain IMPALA-14095? -- To view, visit http://gerrit.cloudera.org:8080/23341 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic855779aa64d11b7a8b19dd261c0164e65604e44 Gerrit-Change-Number: 23341 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Sun, 24 Aug 2025 16:26:24 +0000 Gerrit-HasComments: Yes
