Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23338 )
Change subject: WIP: 4.0 Only gerrit patches ...................................................................... Patch Set 1: (2 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23338/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinRule.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinRule.java: http://gerrit.cloudera.org:8080/#/c/23338/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinRule.java@193 PS1, Line 193: private static void findRemovableOuterJoins(RelMetadataQuery mq, LoptMultiJoin multiJoin) { line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/23338/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinRule.java@350 PS1, Line 350: private static void findRemovableSelfJoins(RelMetadataQuery mq, LoptMultiJoin multiJoin) { line too long (92 > 90) -- To view, visit http://gerrit.cloudera.org:8080/23338 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie91f1ca554af08ffa3c2010fbbc5940a3ddf78bb Gerrit-Change-Number: 23338 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Sat, 23 Aug 2025 00:40:08 +0000 Gerrit-HasComments: Yes
